[libc] Add invoke / invoke_result type traits #65750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gchatelet
changed the title
gchatelet
requested review from
legrosbuffle
and removed request for
legrosbuffle
legrosbuffle
reviewed
Sep 8, 2023
gchatelet
added a commit
that referenced
this pull request
Sep 11, 2023
This is not exhaustive for now but it provides a placeholder for `invoke_result` test mentioned in #65750.
gchatelet
force-pushed
the
invoke_result
branch
from
07281d7 to
d14a049
Compare
gchatelet
changed the title
gchatelet
force-pushed
the
invoke_result
branch
from
9e96a93 to
6b7212b
Compare
legrosbuffle
requested changes
Sep 13, 2023
gchatelet
force-pushed
the
invoke_result
branch
from
6b7212b to
61c3889
Compare
| auto lambda = [](int) -> double { return 0; }; | ||
| EXPECT_TRUE((is_same_v<invoke_result_t<decltype(lambda), int>, double>)); | ||
| } | ||
| } |
There was a problem hiding this comment.
We're missing tests for a functor with overloaded types:
auto lambda = [](auto a) { return a; };
EXPECT_TRUE((is_same_v<invoke_result_t<decltype(lambda), int>, int>));
EXPECT_TRUE((is_same_v<invoke_result_t<decltype(lambda), double>, double>));
maybe also with auto& and auto&&.
There was a problem hiding this comment.
Thx! This helped me catch a bug where the function return type should be decltype(auto) instead of auto for perfect forwarding.
legrosbuffle
approved these changes
Sep 15, 2023
|
Thx for the thorough review @legrosbuffle, I really appreciate it. |
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
This is not exhaustive for now but it provides a placeholder for `invoke_result` test mentioned in llvm#65750.
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.